Put the path to protobuf in front.

Put the path to protobuf in front.

If we don't do that, we might end up using the system protobuf instead.

BUG=

Committed: https://crrev.com/7bdaba41ecfa230339962f72a1866e9d4f77cc8d
Cr-Commit-Position: refs/heads/master@{#387756}

[xyzzyz, 2016-04-15 23:04:22]

xyzzyz@chromium.org changed reviewers:
+ nparker@chromium.org, thestig@chromium.org

[xyzzyz, 2016-04-15 23:04:23]

Hi, 

I am currently updating protobuf to new version, and in the process, I found
that your CL (https://codereview.chromium.org/1878383003/) is broken. 

What is happening here is that when you're adding pyproto/ to the end of the
sys.path, and there's already some protobuf earlier in the path (e.g. system
provided protobuf), you end up using that instead of Chromium one. This breaks
hard if the version used to generate proto bindings (in your case,
download_file_types_pb2) is different than the version imported in the code. See
the output of the buildbot in the issue here:
https://codereview.chromium.org/1895563002
as you can see, the text_format module comes from
/b/build/third_party/site-packages/google/protobuf/text_format.pyc instead of
out/.../pyproto/

Thanks,
Adam

[Nathan Parker, 2016-04-15 23:29:24]

lgtm

Updating protobuf version? Exciting!  From what to what version, and how is it
different?

Thanks for the fix.

[Lei Zhang, 2016-04-15 23:30:47]

lgtm

[xyzzyz, 2016-04-15 23:36:38]

On 2016/04/15 23:29:24, Nathan Parker wrote:
> lgtm
> 
> Updating protobuf version? Exciting!  From what to what version, and how is it
> different?
> 
> Thanks for the fix.

I'm upgrading the protobuf library to version 3. Here's some background:
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/protob...

[xyzzyz, 2016-04-15 23:37:06]

The CQ bit was checked by xyzzyz@chromium.org

[commit-bot: I haz the power, 2016-04-15 23:37:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887423003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887423003/1

[commit-bot: I haz the power, 2016-04-15 23:59:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-16 00:01:08]

Description was changed from

==========
Put the path to protobuf in front.

If we don't do that, we might end up using the system protobuf instead.

BUG=
==========

to

==========
Put the path to protobuf in front.

If we don't do that, we might end up using the system protobuf instead.

BUG=

Committed: https://crrev.com/7bdaba41ecfa230339962f72a1866e9d4f77cc8d
Cr-Commit-Position: refs/heads/master@{#387756}
==========

[commit-bot: I haz the power, 2016-04-16 00:01:09]

Patchset 1 (id:??) landed as
https://crrev.com/7bdaba41ecfa230339962f72a1866e9d4f77cc8d
Cr-Commit-Position: refs/heads/master@{#387756}