Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1887423002: Don't execute the fallback if we already started running the gc callback (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
vogelheim
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't execute the fallback if we already started running the gc callback BUG=603732 R=vogelheim@chromium.org Committed: https://crrev.com/34c97b31e61e8329e19188b46a489412a16d2b63 Cr-Commit-Position: refs/heads/master@{#387578}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M extensions/renderer/gc_callback.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-04-15 11:24:29 UTC) #1
vogelheim
lgtm
4 years, 8 months ago (2016-04-15 11:29:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887423002/20001
4 years, 8 months ago (2016-04-15 11:30:20 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 12:03:27 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 12:05:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34c97b31e61e8329e19188b46a489412a16d2b63
Cr-Commit-Position: refs/heads/master@{#387578}

Powered by Google App Engine
This is Rietveld 408576698