[heap] Remove recorded slots in fixed array header area on left trimming.

[heap] Remove recorded slots in fixed array header area on left trimming.

BUG=

Committed: https://crrev.com/0acd9a4bdf1e9b4a6bc4defc69652ab4d5a88b8a
Cr-Commit-Position: refs/heads/master@{#35540}

[ulan, 2016-04-15 15:23:29]

ulan@chromium.org changed reviewers:
+ jkummerow@google.com, mlippautz@chromium.org

[ulan, 2016-04-15 15:23:29]

PTAL. Left trimming removes recorded slots only in the freed area, not inside
the fixed array.

[ulan, 2016-04-15 15:53:41]

Description was changed from

==========
[heap] Fix assert in verification of remembered set slots.

BUG=
==========

to

==========
[heap] Remove recorded slots in fixed array header area on left trimming.

BUG=
==========

[ulan, 2016-04-15 15:55:31]

On 2016/04/15 15:23:29, ulan wrote:
> PTAL. Left trimming removes recorded slots only in the freed area, not inside
> the fixed array.

After discussion with Michael, we decided to explicitly remove slots
corresponding to map and length on left trimming.
This adds very small perf overhead in release mode, but is cleaner.

[Michael Lippautz, 2016-04-15 15:56:58]

On 2016/04/15 15:55:31, ulan wrote:
> On 2016/04/15 15:23:29, ulan wrote:
> > PTAL. Left trimming removes recorded slots only in the freed area, not
inside
> > the fixed array.
> 
> After discussion with Michael, we decided to explicitly remove slots
> corresponding to map and length on left trimming.
> This adds very small perf overhead in release mode, but is cleaner.

lgtm

[ulan, 2016-04-15 15:57:51]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-04-15 15:57:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/1887343004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-04-15 15:57:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887343004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887343004/40001

[commit-bot: I haz the power, 2016-04-15 18:05:37]

Description was changed from

==========
[heap] Remove recorded slots in fixed array header area on left trimming.

BUG=
==========

to

==========
[heap] Remove recorded slots in fixed array header area on left trimming.

BUG=
==========

[commit-bot: I haz the power, 2016-04-15 18:05:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-15 18:06:33]

Description was changed from

==========
[heap] Remove recorded slots in fixed array header area on left trimming.

BUG=
==========

to

==========
[heap] Remove recorded slots in fixed array header area on left trimming.

BUG=

Committed: https://crrev.com/0acd9a4bdf1e9b4a6bc4defc69652ab4d5a88b8a
Cr-Commit-Position: refs/heads/master@{#35540}
==========

[commit-bot: I haz the power, 2016-04-15 18:06:34]

Patchset 3 (id:??) landed as
https://crrev.com/0acd9a4bdf1e9b4a6bc4defc69652ab4d5a88b8a
Cr-Commit-Position: refs/heads/master@{#35540}