Issue 1887313002: dart2js: Reduce calls to Uri.toString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1887313002: dart2js: Reduce calls to Uri.toString() (Closed)

Created:
4 years, 8 months ago by sra1

Modified:
4 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: Reduce calls to Uri.toString() Uri.toString() shows up at 2% of a full dart2js compile. Avoid by using Uri components or reusing result of toString() BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b887563dff1ed69e32bb9a7d8cb2a18bab57774c

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -18 lines)			Patch
	M	pkg/compiler/lib/src/native/native.dart	View		1 chunk	+24 lines, -18 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

4 years, 8 months ago (2016-04-15 16:00:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b887563dff1ed69e32bb9a7d8cb2a18bab57774c (presubmit successful).