Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1887303002: Collapse whitespace in app names derived from links. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Collapse whitespace in app names derived from links. BUG=602542 Committed: https://crrev.com/0c6252c3dddd58184c40074a5300802a6a9b7f0f Cr-Commit-Position: refs/heads/master@{#387713}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
Happy to add a test if there's an easy way to do it. But I ...
4 years, 8 months ago (2016-04-14 23:54:40 UTC) #2
Evan Stade
lgtm, thanks https://codereview.chromium.org/1887303002/diff/1/chrome/browser/ui/webui/ntp/app_launcher_handler.cc File chrome/browser/ui/webui/ntp/app_launcher_handler.cc (right): https://codereview.chromium.org/1887303002/diff/1/chrome/browser/ui/webui/ntp/app_launcher_handler.cc#newcode725 chrome/browser/ui/webui/ntp/app_launcher_handler.cc:725: title, /* trim_sequences_with_line_breaks=*/false); nit: is the spacing ...
4 years, 8 months ago (2016-04-15 20:47:41 UTC) #3
dcheng
https://codereview.chromium.org/1887303002/diff/1/chrome/browser/ui/webui/ntp/app_launcher_handler.cc File chrome/browser/ui/webui/ntp/app_launcher_handler.cc (right): https://codereview.chromium.org/1887303002/diff/1/chrome/browser/ui/webui/ntp/app_launcher_handler.cc#newcode725 chrome/browser/ui/webui/ntp/app_launcher_handler.cc:725: title, /* trim_sequences_with_line_breaks=*/false); I couldn't remember what our usual ...
4 years, 8 months ago (2016-04-15 21:03:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887303002/20001
4 years, 8 months ago (2016-04-15 21:05:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 22:04:56 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 22:06:31 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0c6252c3dddd58184c40074a5300802a6a9b7f0f
Cr-Commit-Position: refs/heads/master@{#387713}

Powered by Google App Engine
This is Rietveld 408576698