ui/views/mus/platform_window_mus.cc - Issue 1887273002: Revert of mash: Close system tray bubble on click outside its bounds, part 1 (patchset #4 id:60001 …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/mus/platform_window_mus.cc

Issue 1887273002: Revert of mash: Close system tray bubble on click outside its bounds, part 1 (patchset #4 id:60001 … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/mus/platform_window_mus.cc

diff --git a/ui/views/mus/platform_window_mus.cc b/ui/views/mus/platform_window_mus.cc

index 1ae09d182c134d3542b9eb0dfdeafe0a1f96e234..1c21eadd8683776456d27552805bc09805e793f4 100644

--- a/ui/views/mus/platform_window_mus.cc

+++ b/ui/views/mus/platform_window_mus.cc

@@ -227,9 +227,6 @@ void PlatformWindowMus::OnWindowInputEvent(

// It's possible dispatching the event will spin a nested message loop. Ack

// the callback now, otherwise we appear unresponsive for the life of the

// nested message loop.

- // TODO(jamescook): Only ack the event as handled if a nested message loop

- // actually starts, perhaps through an observer on MessageLoop. Otherwise

- // ack the event with the actual handled state below DispatchEvent().

(*ack_callback)->Run(true);

ack_callback->reset();

// TODO(moshayedi): Avoid cloning after updating PlatformWindowDelegate to

« no previous file with comments | « ui/views/bubble/tray_bubble_view.cc ('k') | ui/views/widget/root_view.h » ('j') | no next file with comments »