Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1887263002: Revert of mash: Close system tray bubble on click outside its bounds, part 1 (Closed)

Created:
4 years, 8 months ago by James Cook
Modified:
4 years, 8 months ago
Reviewers:
msw, sadrul, sky
CC:
chromium-reviews, msw+watch_chromium.org, sadrul, tfarina, groby+bubble_chromium.org, hcarmona+bubble_chromium.org, kalyank, rouslan+bubble_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mash: Close system tray bubble on click outside its bounds, part 1 (patchset #4 id:60001 of https://codereview.chromium.org/1876553002/ ) Reason for revert: Breaks clicking in the system tray bubble on mus. We need an entirely different architecture for this. Original issue's description: > mash: Close system tray bubble on click outside its bounds, part 1 > > Mus does not support global event handlers, so the existing TrayEventFilter > cannot be used to close the bubble. Instead we use mouse capture. > > * Capture the mouse explicitly when the bubble is spawned and release it on > clicks outside its bounds. > * Always close the bubble on capture loss, in case some other part of the > window system breaks capture. > > Also fix an issue with auto-release-capture at the widget level. If a view > explicitly requested capture via Widget::SetCapture(my_view) and explicitly > did not request auto-release-capture, then any mouse release event would > cause the view to lose capture (that is, being an explicit mouse handler > target at the RootView level). Fix this so that these sorts of views will > continue to receive events until they explicit release capture. > > Note that this code still eats the mousedown event that causes the bubble to > close. Fixing that is part 2. > > BUG=599142 > > Committed: https://crrev.com/5eb778dc5a2a4762fe95d67f2adc151f928d7939 > Cr-Commit-Position: refs/heads/master@{#386402} TBR=sky@chromium.org,msw@chromium.org,sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=599142

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -116 lines) Patch
M ash/system/tray/system_tray.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/views/bubble/tray_bubble_view.cc View 4 chunks +2 lines, -26 lines 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/root_view.h View 2 chunks +1 line, -11 lines 0 comments Download
M ui/views/widget/root_view.cc View 5 chunks +6 lines, -14 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 4 chunks +14 lines, -51 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
James Cook
4 years, 8 months ago (2016-04-14 22:52:20 UTC) #1
Created Revert of mash: Close system tray bubble on click outside its bounds,
part 1

Powered by Google App Engine
This is Rietveld 408576698