Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 1887253002: Rate limit programmatic update checks for extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix for idleness waiting problem caused by crrev.com/388245 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 43f3ca0f8975bbc3986023d6010c84c264950168..a16b493c81cdf945a48229006093c64e19e60d44 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -518,7 +518,8 @@ bool ExtensionService::UpdateExtension(const extensions::CRXFileInfo& file,
<< " because it is not installed or pending";
// Delete extension_path since we're not creating a CrxInstaller
// that would do it for us.
- if (!GetFileTaskRunner()->PostTask(
+ if (file_ownership_passed &&
+ !GetFileTaskRunner()->PostTask(
FROM_HERE,
base::Bind(&extensions::file_util::DeleteFile, file.path, false)))
NOTREACHED();
@@ -691,12 +692,12 @@ void ExtensionService::ReloadExtensionImpl(
}
void ExtensionService::ReloadExtension(const std::string& extension_id) {
- ReloadExtensionImpl(extension_id, true); // be_noisy
+ ReloadExtensionImpl(extension_id, true); // be_noisy
}
void ExtensionService::ReloadExtensionWithQuietFailure(
const std::string& extension_id) {
- ReloadExtensionImpl(extension_id, false); // be_noisy
+ ReloadExtensionImpl(extension_id, false); // be_noisy
}
bool ExtensionService::UninstallExtension(

Powered by Google App Engine
This is Rietveld 408576698