Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1887233005: Fix all dart:html strong mode errors except for spurious FINAL_NOT_INITIALIZED_CONSTRUCTOR warnings. (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix all dart:html strong mode errors except for spurious FINAL_NOT_INITIALIZED_CONSTRUCTOR warnings. BUG= R=jmesserly@google.com, vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/64ba7710e2458415fbd299361cb40b30c8a8ccdd

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9251 lines, -4579 lines) Patch
M lib/runtime/dart_sdk.js View 1 2 496 chunks +4496 lines, -2240 lines 0 comments Download
M tool/input_sdk/lib/html/dart2js/html_dart2js.dart View 1 2 429 chunks +4681 lines, -2025 lines 0 comments Download
M tool/input_sdk/lib/html/html_common/conversions.dart View 1 2 2 chunks +4 lines, -9 lines 0 comments Download
M tool/input_sdk/lib/html/html_common/conversions_dart2js.dart View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M tool/input_sdk/lib/html/html_common/css_class_set.dart View 1 2 5 chunks +11 lines, -8 lines 0 comments Download
M tool/input_sdk/lib/html/html_common/filtered_element_list.dart View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 2 2 chunks +58 lines, -285 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Jacob
Other ignored warnings are due to not parsing types in JS macro
4 years, 8 months ago (2016-04-20 18:33:33 UTC) #1
Jacob
4 years, 8 months ago (2016-04-20 18:33:51 UTC) #3
vsm
lgtm
4 years, 8 months ago (2016-04-20 19:39:36 UTC) #4
vsm
note, we still have the UNDEFINED_* errors as well.
4 years, 8 months ago (2016-04-20 19:43:52 UTC) #5
Jennifer Messerly
I didn't review html_dart2js.dart, there seems to be a lot of churn in the diff, ...
4 years, 8 months ago (2016-04-20 19:44:01 UTC) #6
vsm
https://codereview.chromium.org/1887233005/diff/10001/tool/sdk_expected_errors.txt File tool/sdk_expected_errors.txt (right): https://codereview.chromium.org/1887233005/diff/10001/tool/sdk_expected_errors.txt#newcode247 tool/sdk_expected_errors.txt:247: severe: [UNDEFINED_METHOD] The method 'convertDartClosureToJS' is not defined for ...
4 years, 8 months ago (2016-04-20 19:45:51 UTC) #7
Jacob
4 years, 8 months ago (2016-04-20 22:31:47 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:20001) manually as
64ba7710e2458415fbd299361cb40b30c8a8ccdd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698