Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1887233004: Make it easy to run `gn format' on an emacs buffer. (Closed)

Created:
4 years, 8 months ago by Elliot Glaysher
Modified:
4 years, 8 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make it easy to run `gn format' on an emacs buffer. BUG=none Committed: https://crrev.com/a67a258a487ec1948d6a6cfc4744cefbab868b5d Cr-Commit-Position: refs/heads/master@{#387727}

Patch Set 1 #

Patch Set 2 : Bad content. Try to upload again. #

Patch Set 3 : Bad content. Try to upload again. #

Patch Set 4 : Bad content. Try to upload again. #

Patch Set 5 : Bad content. Try to upload again. #

Patch Set 6 : Bad content. Try to upload again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M tools/gn/misc/emacs/gn-mode.el View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Elliot Glaysher
4 years, 8 months ago (2016-04-15 21:00:22 UTC) #3
Elliot Glaysher
4 years, 8 months ago (2016-04-15 21:00:23 UTC) #4
Elliot Glaysher
Makes it trivial to run gn format from emacs. (Thought about putting this is the ...
4 years, 8 months ago (2016-04-15 21:01:42 UTC) #5
Roland McGrath
Bad content. Try to upload again.
4 years, 8 months ago (2016-04-15 21:02:36 UTC) #6
Elliot Glaysher
On 2016/04/15 21:02:36, Roland McGrath wrote: > Bad content. Try to upload again. Tried an ...
4 years, 8 months ago (2016-04-15 21:10:53 UTC) #7
Roland McGrath
lgtm
4 years, 8 months ago (2016-04-15 21:21:45 UTC) #8
Elliot Glaysher
brettw for OWNERS stamp
4 years, 8 months ago (2016-04-15 21:24:06 UTC) #10
Dirk Pranke
stampity stamp lgtm.
4 years, 8 months ago (2016-04-15 21:31:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887233004/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887233004/90001
4 years, 8 months ago (2016-04-15 21:45:37 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 8 months ago (2016-04-15 22:28:02 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 22:29:59 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/a67a258a487ec1948d6a6cfc4744cefbab868b5d
Cr-Commit-Position: refs/heads/master@{#387727}

Powered by Google App Engine
This is Rietveld 408576698