Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 188723004: Update Reousrce for 9 Patch Scrollbar (Closed)

Created:
6 years, 9 months ago by weiliangc
Modified:
6 years, 9 months ago
Reviewers:
danakj, oshima
CC:
chromium-reviews, oshima+watch_chromium.org, wjmaclean, DaveMoore, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update Reousrce for 9 Patch Scrollbar For 9 patch scrollbar we want to control stroke and fill separately. Remove original 9 patch scrollbar resources and update them to current ones. BUG=307578 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255760

Patch Set 1 #

Patch Set 2 : reupload until no 500 error #

Patch Set 3 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_active_bottom.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_active_bottom_left.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_active_bottom_right.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_active_center.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_active_left.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_active_right.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_active_top.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_active_top_left.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_active_top_right.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_bottom.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_bottom_left.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_bottom_right.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_center.png View Binary file 0 comments Download
A ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_fill_bottom.png View Binary file 0 comments Download
A + ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_fill_bottom_left.png View Binary file 0 comments Download
A + ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_fill_bottom_right.png View Binary file 0 comments Download
A ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_fill_center.png View Binary file 0 comments Download
A ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_fill_left.png View Binary file 0 comments Download
A ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_fill_right.png View Binary file 0 comments Download
A ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_fill_top.png View Binary file 0 comments Download
A + ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_fill_top_left.png View Binary file 0 comments Download
A + ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_fill_top_right.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_left.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_right.png View Binary file 0 comments Download
A ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_stroke_bottom.png View Binary file 0 comments Download
A + ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_stroke_bottom_left.png View Binary file 0 comments Download
A + ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_stroke_bottom_right.png View Binary file 0 comments Download
A ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_stroke_left.png View Binary file 0 comments Download
A ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_stroke_right.png View Binary file 0 comments Download
A ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_stroke_top.png View Binary file 0 comments Download
A + ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_stroke_top_left.png View Binary file 0 comments Download
A + ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_stroke_top_right.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_top.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_top_left.png View Binary file 0 comments Download
D ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_top_right.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_active_bottom.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_active_bottom_left.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_active_bottom_right.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_active_center.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_active_left.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_active_right.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_active_top.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_active_top_left.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_active_top_right.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_bottom.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_bottom_left.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_bottom_right.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_center.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_fill_bottom.png View Binary file 0 comments Download
A + ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_fill_bottom_left.png View Binary file 0 comments Download
A + ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_fill_bottom_right.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_fill_center.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_fill_left.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_fill_right.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_fill_top.png View Binary file 0 comments Download
A + ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_fill_top_left.png View Binary file 0 comments Download
A + ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_fill_top_right.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_left.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_right.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_stroke_bottom.png View Binary file 0 comments Download
A + ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_stroke_bottom_left.png View Binary file 0 comments Download
A + ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_stroke_bottom_right.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_stroke_left.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_stroke_right.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_stroke_top.png View Binary file 0 comments Download
A + ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_stroke_top_left.png View Binary file 0 comments Download
A + ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_stroke_top_right.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_top.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_top_left.png View Binary file 0 comments Download
D ui/resources/default_200_percent/common/aura_scrollbar_overlay_thumb_top_right.png View Binary file 0 comments Download
M ui/resources/ui_resources.grd View 1 chunk +17 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
weiliangc
overall: danakj owner: oshima
6 years, 9 months ago (2014-03-06 20:48:24 UTC) #1
danakj
LGTM
6 years, 9 months ago (2014-03-06 20:50:08 UTC) #2
oshima
lgtm
6 years, 9 months ago (2014-03-06 22:06:02 UTC) #3
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 9 months ago (2014-03-07 18:42:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/188723004/1
6 years, 9 months ago (2014-03-07 18:44:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 18:44:10 UTC) #6
commit-bot: I haz the power
Can't process patch for file ui/resources/default_100_percent/common/aura_scrollbar_overlay_thumb_stroke_top.png. Binary file is empty. Maybe the file wasn't uploaded ...
6 years, 9 months ago (2014-03-07 18:44:10 UTC) #7
danakj
500 errors on upload? On Fri, Mar 7, 2014 at 1:44 PM, <commit-bot@chromium.org> wrote: > ...
6 years, 9 months ago (2014-03-07 18:47:39 UTC) #8
weiliangc
Not when I uploaded CL. What should I do? On Fri, Mar 7, 2014 at ...
6 years, 9 months ago (2014-03-07 18:50:26 UTC) #9
danakj
I'd try upload again and see what happens.
6 years, 9 months ago (2014-03-07 19:01:02 UTC) #10
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 9 months ago (2014-03-07 21:47:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/188723004/60001
6 years, 9 months ago (2014-03-07 21:49:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/188723004/60001
6 years, 9 months ago (2014-03-08 11:01:58 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 11:54:27 UTC) #14
Message was sent while issue was closed.
Change committed as 255760

Powered by Google App Engine
This is Rietveld 408576698