Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1887213002: Add PropertyAccessorElementForLink_Variable.library getter. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add PropertyAccessorElementForLink_Variable.library getter. Needed by PropertyAccessorElementForLink_Variable.isAccessibleIn(). Also add some toString() methods to aid in debugging. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/8c1bc412932fb113f450e77ca20e64cb87d98979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -17 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 10 chunks +28 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 3 chunks +30 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-14 21:19:54 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-14 21:21:00 UTC) #3
Brian Wilkerson
lgtm
4 years, 8 months ago (2016-04-14 21:21:24 UTC) #4
Paul Berry
4 years, 8 months ago (2016-04-14 21:22:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c1bc412932fb113f450e77ca20e64cb87d98979 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698