Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1887203004: Remove timeline events for Dart_GetNativeX. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove timeline events for Dart_GetNativeX, etc. These are common leaf functions. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b63dc021ea1ed1126bb5bc542b1f0a4a6fa19c2d

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 10 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 8 months ago (2016-04-15 00:39:25 UTC) #2
Cutch
lgtm
4 years, 8 months ago (2016-04-15 13:59:20 UTC) #4
rmacnak
4 years, 8 months ago (2016-04-15 16:31:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b63dc021ea1ed1126bb5bc542b1f0a4a6fa19c2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698