Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 1887173003: Fix an issue that referrer field is no longer exposed to pdfviewer (Closed)

Created:
4 years, 8 months ago by qinmin
Modified:
4 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue that referrer field is no longer exposed to pdfviewer New pdfviewer starts to handle http scheme. As a result, clicking a pdf link will no longer trigger a download. Instead, the navigation will be intercepted and passed to pdfviewer. We previously added the referrer extra for analytics purpose for pdfviewer. But that only happens in the download code. This CL fixes the referrer field issue for intercepted navigations. BUG=603730 Committed: https://crrev.com/30be6d55e09751882232f06ee0db9541d7a201bd Cr-Commit-Position: refs/heads/master@{#388535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
qinmin
PTAL
4 years, 8 months ago (2016-04-14 22:09:20 UTC) #2
Yaron
Do we need both? Users with old pdf viewer won't get the interception?
4 years, 8 months ago (2016-04-14 22:26:37 UTC) #3
qinmin
On 2016/04/14 22:26:37, Yaron wrote: > Do we need both? Users with old pdf viewer ...
4 years, 8 months ago (2016-04-14 22:36:46 UTC) #4
Yaron
On 2016/04/14 22:36:46, qinmin wrote: > On 2016/04/14 22:26:37, Yaron wrote: > > Do we ...
4 years, 8 months ago (2016-04-15 14:23:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887173003/1
4 years, 8 months ago (2016-04-20 16:49:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 18:22:59 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30be6d55e09751882232f06ee0db9541d7a201bd
Cr-Commit-Position: refs/heads/master@{#388535}

Powered by Google App Engine
This is Rietveld 408576698