Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1887163003: clang/win update.py: Put gnuwin last in path. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win update.py: Put gnuwin last in path. gnuwin's rm.exe doesn't seem to work with long path names on the bots for some reason. The bots have cygwin installed and have a better working rm.exe earlier in the path, so try to use this. (Local devs don't have long paths.) BUG=603364 NOTRY=true Committed: https://crrev.com/051cfcb6697da79bd57d47e923505d2ec806cc3a Cr-Commit-Position: refs/heads/master@{#387463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Nico
admittedly a bit hacky, but i don't want to spend a lot of time on ...
4 years, 8 months ago (2016-04-14 20:46:41 UTC) #2
hans
On 2016/04/14 20:46:41, Nico (hiding Wed-Thu) wrote: > admittedly a bit hacky, but i don't ...
4 years, 8 months ago (2016-04-14 22:28:25 UTC) #3
Nico
will do in a follow-up if this helps
4 years, 8 months ago (2016-04-14 22:30:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887163003/1
4 years, 8 months ago (2016-04-14 22:35:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 22:41:24 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/051cfcb6697da79bd57d47e923505d2ec806cc3a Cr-Commit-Position: refs/heads/master@{#387463}
4 years, 8 months ago (2016-04-14 22:42:54 UTC) #11
Nico
4 years, 8 months ago (2016-04-15 14:15:16 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1888353003/ by thakis@chromium.org.

The reason for reverting is: Didn't help: Cygwin is in the PATH when ssh'ing in,
but not for normal build steps on the bot..

Powered by Google App Engine
This is Rietveld 408576698