Issue 1887163002: Fix DDC build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1887163002: Fix DDC build (Closed)

Created:
4 years, 8 months ago by Jennifer Messerly

Modified:
4 years, 8 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org, jakemac

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix DDC build this was a last minute fix for relative paths, but it went wrong and broke the SDK build Committed: https://github.com/dart-lang/dev_compiler/commit/1d4a78a74b42171c5409177cbd88dd3f610c8f2b

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	lib/src/compiler/compiler.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 5 (3 generated)

Jennifer Messerly

TBR. Sorry @jakemac, I'll need to investigate this a bit for a proper test/fix. Analyzer's ...

4 years, 8 months ago (2016-04-14 18:58:03 UTC) #3

Jennifer Messerly

4 years, 8 months ago (2016-04-14 18:58:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1d4a78a74b42171c5409177cbd88dd3f610c8f2b (presubmit successful).