Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1887093002: Put SkEmptyTypeface in anonymous namespace. (Closed)

Created:
4 years, 8 months ago by bungeman-skia
Modified:
4 years, 8 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Put SkEmptyTypeface in anonymous namespace. We ended up with two SkEmptyTypefaces it differnt places. Avoid this odr violation by sticking these in anonymous namespaces. Committed: https://skia.googlesource.com/skia/+/a821af83890d3b365c7b871f939737d47c48139c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/core/SkTypeface.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M tests/TypefaceTest.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887093002/1
4 years, 8 months ago (2016-04-14 16:31:58 UTC) #4
bungeman-skia
4 years, 8 months ago (2016-04-14 16:32:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887093002/1
4 years, 8 months ago (2016-04-14 16:32:39 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-14 16:32:40 UTC) #10
dogben
lgtm
4 years, 8 months ago (2016-04-14 16:36:45 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 16:44:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a821af83890d3b365c7b871f939737d47c48139c

Powered by Google App Engine
This is Rietveld 408576698