Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tests/language/call_test.dart

Issue 188703004: Fix invocation of closures via .call in the VM (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/call_test.dart
===================================================================
--- tests/language/call_test.dart (revision 33570)
+++ tests/language/call_test.dart (working copy)
@@ -1,6 +1,7 @@
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
+// VMOptions=--optimization_counter_threshold=10
import "package:expect/expect.dart";
@@ -8,6 +9,35 @@
bar(a) {
return a is String;
}
- Expect.isFalse(bar(1));
- Expect.isTrue(bar.call('foo'));
+
+ for (var i = 0; i < 20; i++) {
+ Expect.isFalse(bar(1));
+ Expect.isTrue(bar.call('foo'));
+ }
+
+ opt_arg([a = "a"]) => a is String;
+
+ for (var i = 0; i < 20; i++) {
+ Expect.isFalse(opt_arg(1));
+ Expect.isFalse(opt_arg.call(1));
+ Expect.isTrue(opt_arg());
+ Expect.isTrue(opt_arg.call());
+ Expect.isTrue(opt_arg("b"));
+ Expect.isTrue(opt_arg.call("b"));
+ }
+
+ named_arg({x: 11, y: 22}) => "$x$y";
+
+ for (var i = 0; i < 20; i++) {
+ Expect.equals("1122", named_arg());
+ Expect.equals("1122", named_arg.call());
+ Expect.equals("4455", named_arg(y:55, x:44));
+ Expect.equals("4455", named_arg.call(y:55, x:44));
+ Expect.equals("4455", named_arg(x:44, y:55));
+ Expect.equals("4455", named_arg.call(x:44, y:55));
+ }
+
+ Expect.throws(() => bar.call(), (e) => e is NoSuchMethodError);
+ Expect.throws(() => opt_arg.call({x:"p"}), (e) => e is NoSuchMethodError);
+ Expect.throws(() => named_arg.call("p", "q"), (e) => e is NoSuchMethodError);
}
« no previous file with comments | « runtime/vm/raw_object.h ('k') | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698