Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Issue 188703002: Fix for failing asserts in HBoundsCheck code generation on x64: use proper cmp operation width inst… (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix for failing asserts in HBoundsCheck code generation on x64: use proper cmp operation width instead of asserting that Integer32 values should be zero extended. Similar to chromium:345820. BUG=349465 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19694

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review notes applied #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M src/x64/lithium-codegen-x64.cc View 1 chunk +21 lines, -14 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-349465.js View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-03-06 14:28:05 UTC) #1
Toon Verwaest
lgtm with nit https://codereview.chromium.org/188703002/diff/1/test/mjsunit/regress/regress-crbug-349465-1.js File test/mjsunit/regress/regress-crbug-349465-1.js (right): https://codereview.chromium.org/188703002/diff/1/test/mjsunit/regress/regress-crbug-349465-1.js#newcode7 test/mjsunit/regress/regress-crbug-349465-1.js:7: __v_1 = new Int32Array(1024); Could you ...
6 years, 9 months ago (2014-03-06 15:39:18 UTC) #2
Igor Sheludko
Committed patchset #2 manually as r19694 (tree was closed).
6 years, 9 months ago (2014-03-06 16:22:54 UTC) #3
Igor Sheludko
6 years, 9 months ago (2014-03-06 17:21:20 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/188703002/diff/1/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-crbug-349465-1.js (right):

https://codereview.chromium.org/188703002/diff/1/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-crbug-349465-1.js:7: __v_1 = new Int32Array(1024);
On 2014/03/06 15:39:19, Toon Verwaest wrote:
> Could you please sanitize these tests a bit? Try to reduce as much as
possible,
> and remove all the __ stuff. That'll just make it easier to understand the
test
> in the future.

Done.

Powered by Google App Engine
This is Rietveld 408576698