Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1887003004: S390: Visit the Optimized Code Map on first call rather than closure creation. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Visit the Optimized Code Map on first call rather than closure creation. Port 9336f4cc6d25d39a128176679a70dbd13a6d946e Original commit message: This is useful for escape analysis, and helps upcoming changes to type feedback gathering. R=mvstanton@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/b141154331c1e5584d98e0f0c3e3e1f1d34435a9 Cr-Commit-Position: refs/heads/master@{#35534}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add knear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -3 lines) Patch
M src/s390/builtins-s390.cc View 1 1 chunk +140 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887003004/1
4 years, 8 months ago (2016-04-15 11:15:09 UTC) #2
john.yan
PTAL
4 years, 8 months ago (2016-04-15 11:15:49 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 11:35:17 UTC) #5
JoranSiu
https://codereview.chromium.org/1887003004/diff/1/src/s390/builtins-s390.cc File src/s390/builtins-s390.cc (right): https://codereview.chromium.org/1887003004/diff/1/src/s390/builtins-s390.cc#newcode1268 src/s390/builtins-s390.cc:1268: __ bne(&loop_bottom); Please add Label::kNear https://codereview.chromium.org/1887003004/diff/1/src/s390/builtins-s390.cc#newcode1275 src/s390/builtins-s390.cc:1275: __ bne(&loop_bottom); ...
4 years, 8 months ago (2016-04-15 12:01:27 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887003004/20001
4 years, 8 months ago (2016-04-15 12:14:46 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 12:51:20 UTC) #10
JoranSiu
lgtm
4 years, 8 months ago (2016-04-15 13:33:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1887003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1887003004/20001
4 years, 8 months ago (2016-04-15 13:47:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 13:55:18 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 13:56:11 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b141154331c1e5584d98e0f0c3e3e1f1d34435a9
Cr-Commit-Position: refs/heads/master@{#35534}

Powered by Google App Engine
This is Rietveld 408576698