Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 1886983003: Add a crash for debugging when we get into a bad state. (Closed)

Created:
4 years, 8 months ago by Elliot Glaysher
Modified:
4 years, 8 months ago
Reviewers:
danakj, Tom Anderson
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a crash for debugging when we get into a bad state. This will crash chrome whenever we receive a MapNotify outside of our calling XMapWindow(). BUG=381732 Committed: https://crrev.com/56cc0f5cd062625b39f7e4d1f326313ea010383b Cr-Commit-Position: refs/heads/master@{#387637}

Patch Set 1 #

Patch Set 2 : set flase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Elliot Glaysher
Added a debug crash for that hang.
4 years, 8 months ago (2016-04-14 23:03:51 UTC) #3
danakj
LGTM
4 years, 8 months ago (2016-04-14 23:27:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886983003/20001
4 years, 8 months ago (2016-04-15 17:03:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 17:47:31 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 17:49:10 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/56cc0f5cd062625b39f7e4d1f326313ea010383b
Cr-Commit-Position: refs/heads/master@{#387637}

Powered by Google App Engine
This is Rietveld 408576698