Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1886983002: [build] Use MSVS 2015 by default.

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Use MSVS 2015 by default. BUG=chromium:603131 LOG=y Committed: https://crrev.com/e51e8b4ad77008ec7f88c144853e01001dbea900 Cr-Commit-Position: refs/heads/master@{#35487}

Patch Set 1 #

Patch Set 2 : Disable warning #

Patch Set 3 : Expose MSVS version in isolate config #

Patch Set 4 : Port shared libs config #

Patch Set 5 : Rebase #

Patch Set 6 : Use exit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -7 lines) Patch
M gypfiles/config/win/msvs_dependencies.isolate View 1 2 3 4 4 chunks +104 lines, -1 line 0 comments Download
M gypfiles/get_landmines.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gypfiles/isolate.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M gypfiles/standalone.gypi View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M gypfiles/vs_toolchain.py View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/d8.cc View 1 2 3 4 5 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886983002/1
4 years, 8 months ago (2016-04-14 09:28:31 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/198)
4 years, 8 months ago (2016-04-14 09:35:22 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886983002/20001
4 years, 8 months ago (2016-04-14 09:56:51 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886983002/40001
4 years, 8 months ago (2016-04-14 10:14:19 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/208) v8_win_nosnap_shared_rel_ng_triggered on ...
4 years, 8 months ago (2016-04-14 10:28:07 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886983002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886983002/60001
4 years, 8 months ago (2016-04-14 10:33:14 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 10:55:25 UTC) #16
Michael Achenbach
PTAL
4 years, 8 months ago (2016-04-14 11:33:15 UTC) #18
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-14 11:35:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886983002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886983002/60001
4 years, 8 months ago (2016-04-14 11:37:28 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-14 11:39:29 UTC) #23
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e51e8b4ad77008ec7f88c144853e01001dbea900 Cr-Commit-Position: refs/heads/master@{#35487}
4 years, 8 months ago (2016-04-14 11:41:21 UTC) #25
Michael Achenbach
4 years, 8 months ago (2016-04-14 14:52:53 UTC) #26
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1890873002/ by machenbach@chromium.org.

The reason for reverting is: Introduced flaky crashes on win debug..

Powered by Google App Engine
This is Rietveld 408576698