Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1886973004: Log the GN args again in `mb gen`. (Closed)

Created:
4 years, 8 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
Reviewers:
krasin1, krasin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log the GN args again in `mb gen`. When I switched MB to write the GN args directly to args.gn in the build directory, I dropped the logic that made sure that got logged. Putting that back in. TBR=krasin@chromium.org BUG=603787 Committed: https://crrev.com/4ff8b9f33499e3ea73a95e02271ba75a4613b2e8 Cr-Commit-Position: refs/heads/master@{#387529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M tools/mb/mb.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/mb/mb_unittest.py View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
4 years, 8 months ago (2016-04-15 01:41:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886973004/1
4 years, 8 months ago (2016-04-15 01:42:01 UTC) #3
Dirk Pranke
tbr'ing since this is a relatively simple build fix.
4 years, 8 months ago (2016-04-15 01:42:07 UTC) #4
krasin
LGTM Thank you for the quick fix!
4 years, 8 months ago (2016-04-15 01:53:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 03:08:07 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 03:09:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ff8b9f33499e3ea73a95e02271ba75a4613b2e8
Cr-Commit-Position: refs/heads/master@{#387529}

Powered by Google App Engine
This is Rietveld 408576698