Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Issue 1886943002: Change ContentSettingImageView activation to key release (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sharing is caring Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
index 99ac8ad74536cd0b0e3c7dcfc5436f1809191282..11e1bbdfdf4c82c7a9b6531b23a442bfeb2e5de9 100644
--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
@@ -74,9 +74,14 @@ class IconLabelBubbleView : public views::InkDropHostView {
// Returns true when animation is in progress and is shrinking.
virtual bool IsShrinking() const;
+ // The view has been activated by a user gesture such as spacebar. Returns
+ // true if some handling was performed.
+ virtual bool OnActivate();
+
// views::View:
gfx::Size GetPreferredSize() const override;
void Layout() override;
+ bool OnKeyReleased(const ui::KeyEvent& event) override;
void OnNativeThemeChanged(const ui::NativeTheme* native_theme) override;
void AddInkDropLayer(ui::Layer* ink_drop_layer) override;
void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;

Powered by Google App Engine
This is Rietveld 408576698