Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 188693007: Added checks for integer overflow conditions to deleteData and replaceData. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed typo Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/dom/CharacterData.cpp ('K') | « Source/core/dom/CharacterData.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index 23ed26c171e1e9047368c79b5a16472e77bd720a..6af027ec7556b95f592bfe0641eeb082bb697d6b 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -383,7 +383,7 @@ static Position updatePositionAfterAdoptingTextReplacement(const Position& posit
if (positionOffset > offset + oldLength)
positionOffset = positionOffset - oldLength + newLength;
- ASSERT(positionOffset <= node->length());
+ ASSERT_WITH_SECURITY_IMPLICATION(positionOffset <= node->length());
// CharacterNode in VisibleSelection must be Text node, because Comment
// and ProcessingInstruction node aren't visible.
return Position(toText(node), positionOffset);
« Source/core/dom/CharacterData.cpp ('K') | « Source/core/dom/CharacterData.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698