LayoutTests/fast/dom/Range/deleteData-replaceData-count-overflow.html - Issue 188693007: Added checks for integer overflow conditions to deleteData and replaceData.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Range/deleteData-replaceData-count-overflow.html

Issue 188693007: Added checks for integer overflow conditions to deleteData and replaceData. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed typo Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <p>This test checks to make sure that deleteData does not overflow with a large 'count' parameter</p>

	5 <div id="result1">FAIL</div>

	6 <div id="result2">FAIL</div>

	7 <script type="text/javascript">

	8 var a = new Text("aaaaaaaaaa");

	9 document.body.appendChild(a);

	10

	11 document.getSelection().extend(a, 10);

	12 range = document.getSelection().getRangeAt(0);

	13

	14 try {

	15 a.deleteData(9, 0xfffffff7);

	16 } catch(ex) {

	17 document.getElementById("result1").innerText = "deleteData - PASS";

	18 }

	19

	20 window.getSelection().removeAllRanges();

	21

	22 var b = new Text("bbbbbbbbbb");

	23 document.body.appendChild(b);

	24

	25 document.getSelection().extend(b, 10);

	26 range = document.getSelection().getRangeAt(0);

	27

	28 try {
	Inactive 2014/03/17 00:04:33 It would also be nice if this test used js-test.js It would also be nice if this test used js-test.js and shouldThrow() so that we can check for a particular type of exception. This would also make the test shorter / simpler.
	29 b.replaceData(9, 0xfffffff7);

	30 } catch(ex) {

	31 document.getElementById("result2").innerText = "replaceData - PASS";

	32 }

	33

	34 if (window.testRunner) {

	35 window.testRunner.dumpAsText();

	36 }

	37 </script>

	38 </body>

	39 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Range/deleteData-replaceData-count-overflow-expected.txt » ('j') | Source/core/dom/CharacterData.cpp » ('J')