Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1886903002: [Mac] Restore menu position for buttons after Material Design changes. (Closed)

Created:
4 years, 8 months ago by shrike
Modified:
4 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Restore menu position for buttons after Material Design changes. Changing the button active area from 28x28 to 24x24 caused button menus to be slightly mispositioned. This change restores their position to normal. R=avi@chromium.org BUG=602672 Committed: https://crrev.com/5d2416adbf662a8c646ba7aa2f47e0fc0de600a4 Cr-Commit-Position: refs/heads/master@{#387160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/menu_button.mm View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 8 months ago (2016-04-13 22:53:34 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-13 23:00:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886903002/1
4 years, 8 months ago (2016-04-13 23:08:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 00:00:08 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 00:01:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d2416adbf662a8c646ba7aa2f47e0fc0de600a4
Cr-Commit-Position: refs/heads/master@{#387160}

Powered by Google App Engine
This is Rietveld 408576698