Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issue 1886893006: Implement SyntheticVariableElementForLink.isSynthetic. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement SyntheticVariableElementForLink.isSynthetic. Needed by PropertyAccessorMember._isChangedByTypeSubstitution. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/3bb4de46f987a5c09de10d9f498cf13db53bf94d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-15 14:00:17 UTC) #2
scheglov
LGTM
4 years, 8 months ago (2016-04-15 14:01:45 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 3bb4de46f987a5c09de10d9f498cf13db53bf94d (presubmit successful).
4 years, 8 months ago (2016-04-15 14:07:40 UTC) #5
Brian Wilkerson
4 years, 8 months ago (2016-04-15 14:09:10 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698