Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1886813004: ABANDONED CL - Removing unused field - LevelDBWrapperImpl::database_ (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, darin-cc_chromium.org, jam, ncarter (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ABANDONED - this code is being actively worked on, so we should not remove fields (even unused) from stubs. -------------------- Removing unused field - LevelDBWrapperImpl::database_ BUG=600434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/leveldb_wrapper_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Łukasz Anforowicz
erg@, could you please take a look? I am removing fields that Scythe (go/scythe, Googlers ...
4 years, 8 months ago (2016-04-14 19:18:38 UTC) #2
Elliot Glaysher
On 2016/04/14 19:18:38, Łukasz Anforowicz wrote: > erg@, could you please take a look? I ...
4 years, 8 months ago (2016-04-14 20:14:23 UTC) #3
Łukasz Anforowicz
4 years, 8 months ago (2016-04-14 20:19:43 UTC) #4 
On 2016/04/14 20:14:23, Elliot Glaysher wrote:
> On 2016/04/14 19:18:38, Łukasz Anforowicz wrote:
> > erg@, could you please take a look?  I am removing fields that Scythe
> > (go/scythe, Googlers only :-/ ) says are not used and it seems that
> > LevelDBWrapperImpl::database_ is not used today.  OTOH, as nick@ points out
> [1]
> > leveldb is being actively worked on [2] so maybe I ought to leave the field
> > alone?
> > 
> > [1]
> >
>
https://codereview.chromium.org/1875463002/diff/270001/content/browser/leveld...
> > 
> > [2]
> >
>
https://chromium.googlesource.com/chromium/src/+/c112794307cc4858616f5aeaa05d...
> 
> Not LGTM
> 
> This is actively being worked on; you are removing things from a stub that's
> currently being implemented.

Great - thanks for looking.  I'll abandon and close this CL.

Powered by Google App Engine
This is Rietveld 408576698