Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1886773005:
Turn on FRAMEBUFFER_SRGB on desktop GL. (Closed)
|
Created:
4 years, 8 months ago by Zhenyao Mo Modified:
4 years, 8 months ago CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), bajones Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTurn on FRAMEBUFFER_SRGB on desktop GL.
For ES3, it is on by default.
BUG=429053
TEST=conformance2/reading/read-pixels-from-fbo.html
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
Committed: https://crrev.com/2d1321caf2011f5bd4aa144915ba5e6c03f8a014
Cr-Commit-Position: refs/heads/master@{#387215}
Patch Set 1 #
Total comments: 2
Patch Set 2 : add comment #
Messages
Total messages: 19 (8 generated)
Description was changed from ========== Turn on FRAMEBUFFER_SRGB on desktop GL. For ES3, it is on by default. BUG=429053 TEST=conformance2/reading/read-pixels-from-fbo.html R=piman@chromium.org ========== to ========== Turn on FRAMEBUFFER_SRGB on desktop GL. For ES3, it is on by default. BUG=429053 TEST=conformance2/reading/read-pixels-from-fbo.html R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by zmo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886773005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886773005/1
Description was changed from ========== Turn on FRAMEBUFFER_SRGB on desktop GL. For ES3, it is on by default. BUG=429053 TEST=conformance2/reading/read-pixels-from-fbo.html R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Turn on FRAMEBUFFER_SRGB on desktop GL. For ES3, it is on by default. BUG=429053 TEST=conformance2/reading/read-pixels-from-fbo.html R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
With this CL, read-pixels-from-fbo.html sRGB cases begin to pass on Linux/Mac. I didn't remove the entry from expectations pending a fix on precision to be rolled in. piman: PTAL Others:FYI
kbr@chromium.org changed reviewers: + kbr@chromium.org
lgtm fwiw, but I'm not an OWNER https://codereview.chromium.org/1886773005/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/1886773005/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_decoder.cc:3037: if (feature_info_->gl_version_info().IsAtLeastGL(3, 2)) { Could you add a comment here describing the effect?
https://codereview.chromium.org/1886773005/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/1886773005/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_decoder.cc:3037: if (feature_info_->gl_version_info().IsAtLeastGL(3, 2)) { On 2016/04/14 00:18:23, Ken Russell wrote: > Could you add a comment here describing the effect? Done.
Still lgtm.
lgtm
Description was changed from ========== Turn on FRAMEBUFFER_SRGB on desktop GL. For ES3, it is on by default. BUG=429053 TEST=conformance2/reading/read-pixels-from-fbo.html R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Turn on FRAMEBUFFER_SRGB on desktop GL. For ES3, it is on by default. BUG=429053 TEST=conformance2/reading/read-pixels-from-fbo.html R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ==========
patch set 2 only added comments, so landing with NOTRY=true (see try jobs for patch set 1)
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886773005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886773005/20001
Message was sent while issue was closed.
Description was changed from ========== Turn on FRAMEBUFFER_SRGB on desktop GL. For ES3, it is on by default. BUG=429053 TEST=conformance2/reading/read-pixels-from-fbo.html R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ========== to ========== Turn on FRAMEBUFFER_SRGB on desktop GL. For ES3, it is on by default. BUG=429053 TEST=conformance2/reading/read-pixels-from-fbo.html R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Turn on FRAMEBUFFER_SRGB on desktop GL. For ES3, it is on by default. BUG=429053 TEST=conformance2/reading/read-pixels-from-fbo.html R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ========== to ========== Turn on FRAMEBUFFER_SRGB on desktop GL. For ES3, it is on by default. BUG=429053 TEST=conformance2/reading/read-pixels-from-fbo.html R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/2d1321caf2011f5bd4aa144915ba5e6c03f8a014 Cr-Commit-Position: refs/heads/master@{#387215} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2d1321caf2011f5bd4aa144915ba5e6c03f8a014 Cr-Commit-Position: refs/heads/master@{#387215}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1888683002/ by piman@chromium.org. The reason for reverting is: Seems to break rendering on linux - see crbug.com/603371. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
