Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1886723003: MIPS: [compiler] Add relocatable pointer constants for wasm memory references. (Closed)

Created:
4 years, 8 months ago by Ilija.Pavlovic1
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [compiler] Add relocatable pointer constants for wasm memory references. Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. Port 52148c41c948f4e70778de758fb1a0ae118cecc2 TEST= BUG= Committed: https://crrev.com/ec5995a1049375dcd0df1fb9bb7d7351edb98112 Cr-Commit-Position: refs/heads/master@{#35450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Ilija.Pavlovic1
PTAL
4 years, 8 months ago (2016-04-13 12:25:39 UTC) #2
akos.palfi.imgtec
LGTM
4 years, 8 months ago (2016-04-13 14:55:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886723003/1
4 years, 8 months ago (2016-04-13 15:02:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 15:21:31 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 15:22:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec5995a1049375dcd0df1fb9bb7d7351edb98112
Cr-Commit-Position: refs/heads/master@{#35450}

Powered by Google App Engine
This is Rietveld 408576698