Remove unused FWL methods

Remove unused FWL methods

This CL removes various methods from FWL that are not called.

Committed: https://pdfium.googlesource.com/pdfium/+/c4c17fbbcf4cd2b72af7c10db0320d78099df66d

[dsinclair, 2016-04-13 20:07:46]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-13 20:07:47]

PTAL.

https://codereview.chromium.org/1886703005/diff/1/xfa/fwl/core/fwl_noteimp.cpp
File xfa/fwl/core/fwl_noteimp.cpp (left):

https://codereview.chromium.org/1886703005/diff/1/xfa/fwl/core/fwl_noteimp.cp...
xfa/fwl/core/fwl_noteimp.cpp:30: return TranslateAccelerator(pMessage);
TranslateAccelerator would always return FALSE since there are never any
accelerators set. Removed this whole method as it would just return FALSE.

[Tom Sepez, 2016-04-13 20:13:28]

lgtm

https://codereview.chromium.org/1886703005/diff/1/xfa/fwl/core/fwl_noteimp.h
File xfa/fwl/core/fwl_noteimp.h (right):

https://codereview.chromium.org/1886703005/diff/1/xfa/fwl/core/fwl_noteimp.h#...
xfa/fwl/core/fwl_noteimp.h:32: ~CFWL_NoteLoop() override {}
nit: implementation should be in .cpp file, even if it's empty since it's
virtual.

[dsinclair, 2016-04-13 20:17:17]

https://codereview.chromium.org/1886703005/diff/1/xfa/fwl/core/fwl_noteimp.h
File xfa/fwl/core/fwl_noteimp.h (right):

https://codereview.chromium.org/1886703005/diff/1/xfa/fwl/core/fwl_noteimp.h#...
xfa/fwl/core/fwl_noteimp.h:32: ~CFWL_NoteLoop() override {}
On 2016/04/13 20:13:28, Tom Sepez wrote:
> nit: implementation should be in .cpp file, even if it's empty since it's
> virtual.


Ack. There are a lot of these at the moment. My plan is to do a pass with the
clang chrome plugin enabled which will complain about these and fix them all at
that point.

[dsinclair, 2016-04-13 20:18:18]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-13 20:18:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1886703005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1886703005/1

[commit-bot: I haz the power, 2016-04-13 20:24:42]

Description was changed from

==========
Remove unused FWL methods

This CL removes various methods from FWL that are not called.
==========

to

==========
Remove unused FWL methods

This CL removes various methods from FWL that are not called.

Committed:
https://pdfium.googlesource.com/pdfium/+/c4c17fbbcf4cd2b72af7c10db0320d78099d...
==========

[commit-bot: I haz the power, 2016-04-13 20:24:43]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c4c17fbbcf4cd2b72af7c10db0320d78099d...