Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: third_party/WebKit/Source/core/layout/ColumnBalancer.h

Issue 1886703002: ColumnBalancer: don't skip bounds checking on first or last fragmentainer groups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ColumnBalancer.h
diff --git a/third_party/WebKit/Source/core/layout/ColumnBalancer.h b/third_party/WebKit/Source/core/layout/ColumnBalancer.h
index e559e05a4028d6c9e98489e128e02412e8cde9b6..40fd612c4f522ca49773b5a17b546d94680b132c 100644
--- a/third_party/WebKit/Source/core/layout/ColumnBalancer.h
+++ b/third_party/WebKit/Source/core/layout/ColumnBalancer.h
@@ -33,14 +33,14 @@ protected:
bool isLogicalTopWithinBounds(LayoutUnit logicalTopInFlowThread) const
{
- return (m_group.isFirstGroup() || logicalTopInFlowThread >= m_group.logicalTopInFlowThread())
- && (m_group.isLastGroup() || logicalTopInFlowThread < m_group.logicalBottomInFlowThread());
+ return logicalTopInFlowThread >= m_group.logicalTopInFlowThread()
+ && logicalTopInFlowThread < m_group.logicalBottomInFlowThread();
}
bool isLogicalBottomWithinBounds(LayoutUnit logicalBottomInFlowThread) const
{
- return (m_group.isFirstGroup() || logicalBottomInFlowThread > m_group.logicalTopInFlowThread())
- && (m_group.isLastGroup() || logicalBottomInFlowThread <= m_group.logicalBottomInFlowThread());
+ return logicalBottomInFlowThread > m_group.logicalTopInFlowThread()
+ && logicalBottomInFlowThread <= m_group.logicalBottomInFlowThread();
}
// Examine and collect column balancing data from a layout box that has been found to intersect
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698