Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1886703002: ColumnBalancer: don't skip bounds checking on first or last fragmentainer groups. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ColumnBalancer: don't skip bounds checking on first or last fragmentainer groups. There should be no need for this special-code. Whatever manages to end up before the first column or after the last one is totally uninteresting to the column balancer. Committed: https://crrev.com/51ac56bc71870f548726e2447f85033673b8013a Cr-Commit-Position: refs/heads/master@{#387150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/ColumnBalancer.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-13 13:45:57 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 8 months ago (2016-04-13 22:10:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886703002/1
4 years, 8 months ago (2016-04-13 22:11:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 23:43:45 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/51ac56bc71870f548726e2447f85033673b8013a Cr-Commit-Position: refs/heads/master@{#387150}
4 years, 8 months ago (2016-04-13 23:45:31 UTC) #8
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-18 11:00:49 UTC) #9
Message was sent while issue was closed.
Turns out that this fixed bug 594285.

Powered by Google App Engine
This is Rietveld 408576698