Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1886683002: Add promise_resolver.js to PolymerTest libraries (Closed)

Created:
4 years, 8 months ago by michaelpg
Modified:
4 years, 8 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add promise_resolver.js to PolymerTest libraries PromiseResolver is a basic pattern in the intersection of Polymer and tests (especially in mocha). BUG=none R=dpapad@chromium.org Committed: https://crrev.com/caf012a15033ebedf2096d601b3378bacbf91ace Cr-Commit-Position: refs/heads/master@{#387034}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/test/data/webui/polymer_browser_test_base.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 9 chunks +0 lines, -9 lines 0 comments Download
M chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
michaelpg
4 years, 8 months ago (2016-04-13 07:52:48 UTC) #2
dpapad
LGTM. Perhaps we could also add test_browser_proxy.js. PromiseResolver is used by TestBrowserProxy base class, which ...
4 years, 8 months ago (2016-04-13 17:24:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886683002/20001
4 years, 8 months ago (2016-04-13 17:26:20 UTC) #5
michaelpg
On 2016/04/13 17:24:11, dpapad wrote: > LGTM. Perhaps we could also add test_browser_proxy.js. PromiseResolver is ...
4 years, 8 months ago (2016-04-13 17:26:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 18:25:41 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:28:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/caf012a15033ebedf2096d601b3378bacbf91ace
Cr-Commit-Position: refs/heads/master@{#387034}

Powered by Google App Engine
This is Rietveld 408576698