Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1886663003:
Measure how many pages are using cross-origin XHR with withCredentials set to true (Closed)
|
Created:
4 years, 8 months ago by tyoshino (SeeGerritForStatus) Modified:
4 years, 8 months ago CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org, asvitkine+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMeasure how many pages are using cross-origin XHR with withCredentials set to true
BUG=602925
R=yhirano,isherman,japhet
Committed: https://crrev.com/9dab7242edcef547fe54c1ed2c8043f70a456bf6
Cr-Commit-Position: refs/heads/master@{#387570}
Patch Set 1 #Patch Set 2 : FIxed #
Total comments: 2
Patch Set 3 : Fixed condition #Patch Set 4 : Rebase #
Messages
Total messages: 28 (13 generated)
Description was changed from ========== Measure how many pages are using cross-origin XHR with withCredentials set to true BUG=602925 ========== to ========== Measure how many pages are using cross-origin XHR with withCredentials set to true BUG=602925 ==========
tyoshino@chromium.org changed reviewers: + yhirano@chromium.org
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886663003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886663003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yhirano, please review this.
https://codereview.chromium.org/1886663003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp (right): https://codereview.chromium.org/1886663003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp:877: if (m_sameOriginRequest && m_includeCredentials) !m_sameOriginRequest?
https://codereview.chromium.org/1886663003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp (right): https://codereview.chromium.org/1886663003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp:877: if (m_sameOriginRequest && m_includeCredentials) On 2016/04/14 04:26:02, yhirano wrote: > !m_sameOriginRequest? My bad... Fixed
lgtm
tyoshino@chromium.org changed reviewers: + isherman@chromium.org
+isherman
tyoshino@chromium.org changed reviewers: + japhet@chromium.org
+japhet
histograms.xml lgtm
lgtm
Description was changed from ========== Measure how many pages are using cross-origin XHR with withCredentials set to true BUG=602925 ========== to ========== Measure how many pages are using cross-origin XHR with withCredentials set to true BUG=602925 R=yhirano,isherman,japhet ==========
The CQ bit was checked by tyoshino@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org, isherman@chromium.org, yhirano@chromium.org Link to the patchset: https://codereview.chromium.org/1886663003/#ps50001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886663003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886663003/50001
Message was sent while issue was closed.
Description was changed from ========== Measure how many pages are using cross-origin XHR with withCredentials set to true BUG=602925 R=yhirano,isherman,japhet ========== to ========== Measure how many pages are using cross-origin XHR with withCredentials set to true BUG=602925 R=yhirano,isherman,japhet ==========
Message was sent while issue was closed.
Committed patchset #4 (id:50001)
Message was sent while issue was closed.
Description was changed from ========== Measure how many pages are using cross-origin XHR with withCredentials set to true BUG=602925 R=yhirano,isherman,japhet ========== to ========== Measure how many pages are using cross-origin XHR with withCredentials set to true BUG=602925 R=yhirano,isherman,japhet Committed: https://crrev.com/9dab7242edcef547fe54c1ed2c8043f70a456bf6 Cr-Commit-Position: refs/heads/master@{#387570} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/9dab7242edcef547fe54c1ed2c8043f70a456bf6 Cr-Commit-Position: refs/heads/master@{#387570} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
