Issue 1886633002: Properly handle unfinalized type parameters of generic mixins (fixes #26230).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1886633002: Properly handle unfinalized type parameters of generic mixins (fixes #26230). (Closed)

Created:
4 years, 8 months ago by regis

Modified:
4 years, 8 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Properly handle unfinalized type parameters of generic mixins (fixes #26230). Finalize upper bounds of unfinalized classes earlier in order to reduce the number of BoundedType allocations. Add regression test. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/b8bcb5587b1115b13532241810aa7d5d08de470e

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -6 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	3 chunks	+7 lines, -4 lines	0 comments	Download
A	tests/language/regress_26230_test.dart	View	1 chunk	+27 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

regis

4 years, 8 months ago (2016-04-13 17:04:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b8bcb5587b1115b13532241810aa7d5d08de470e (presubmit successful).