Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1886583002: Add a temporary timeout and print in the safepoint waiter to log if we are stuck waiting for a thre… (Closed)

Created:
4 years, 8 months ago by siva
Modified:
4 years, 8 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a temporary timeout and print in the safepoint waiter to log if we are stuck waiting for a thread to safepoint, this will help detect if some timeouts in the build bots is because of this. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/8311c49799132b96dac27605298258da96eadf6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M runtime/vm/safepoint.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 8 months ago (2016-04-12 21:13:06 UTC) #2
srdjan
lgtm
4 years, 8 months ago (2016-04-12 21:44:04 UTC) #3
siva
4 years, 8 months ago (2016-04-12 22:35:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8311c49799132b96dac27605298258da96eadf6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698