Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Issue 1886573003: Disable WebViewTextInputStateInteractiveTest.TopLevelWebContentsTracksCorrectly on Win (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add bug reference Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 1361 matching lines...) Expand 10 before | Expand all | Expand 10 after
1372 for (size_t i = 0; i < 4; ++i) 1372 for (size_t i = 0; i < 4; ++i)
1373 SendKeyPressToPlatformApp(ui::VKEY_TAB); 1373 SendKeyPressToPlatformApp(ui::VKEY_TAB);
1374 ExtensionTestMessageListener webview_button_not_focused_listener( 1374 ExtensionTestMessageListener webview_button_not_focused_listener(
1375 "WebViewInteractiveTest.WebViewButtonWasNotFocused", false); 1375 "WebViewInteractiveTest.WebViewButtonWasNotFocused", false);
1376 webview_button_not_focused_listener.set_failure_message( 1376 webview_button_not_focused_listener.set_failure_message(
1377 "WebViewInteractiveTest.WebViewButtonWasFocused"); 1377 "WebViewInteractiveTest.WebViewButtonWasFocused");
1378 SendMessageToEmbedder("verify"); 1378 SendMessageToEmbedder("verify");
1379 EXPECT_TRUE(webview_button_not_focused_listener.WaitUntilSatisfied()); 1379 EXPECT_TRUE(webview_button_not_focused_listener.WaitUntilSatisfied());
1380 } 1380 }
1381 1381
1382 // TODO(crbug.com/602954) Test is flaky.
1383 #if defined(OS_WIN)
1384 #define MAYBE_TopLevelWebContentsTracksCorrectly \
1385 DISABLED_TopLevelWebContentsTracksCorrectly
1386 #else
1387 #define MAYBE_TopLevelWebContentsTracksCorrectly \
1388 TopLevelWebContentsTracksCorrectly
1389 #endif
1382 IN_PROC_BROWSER_TEST_P(WebViewTextInputStateInteractiveTest, 1390 IN_PROC_BROWSER_TEST_P(WebViewTextInputStateInteractiveTest,
1383 TopLevelWebContentsTracksCorrectly) { 1391 MAYBE_TopLevelWebContentsTracksCorrectly) {
1384 SetupTest("web_view/text_input_state", 1392 SetupTest("web_view/text_input_state",
1385 "/extensions/platform_apps/web_view/text_input_state/guest.html"); 1393 "/extensions/platform_apps/web_view/text_input_state/guest.html");
1386 1394
1387 auto press_tab_to_focus = [](WebViewTextInputStateInteractiveTest* test, 1395 auto press_tab_to_focus = [](WebViewTextInputStateInteractiveTest* test,
1388 const std::string& message) { 1396 const std::string& message) {
1389 ExtensionTestMessageListener listener(message, false); 1397 ExtensionTestMessageListener listener(message, false);
1390 test->SendKeyPressToPlatformApp(ui::VKEY_TAB); 1398 test->SendKeyPressToPlatformApp(ui::VKEY_TAB);
1391 listener.WaitUntilSatisfied(); 1399 listener.WaitUntilSatisfied();
1392 }; 1400 };
1393 1401
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
1436 1444
1437 // Now crash the <webview>. 1445 // Now crash the <webview>.
1438 guest_web_contents()->GetRenderProcessHost()->Shutdown(false, 0); 1446 guest_web_contents()->GetRenderProcessHost()->Shutdown(false, 0);
1439 1447
1440 // State should reset to none. 1448 // State should reset to none.
1441 TextInputStateHelper::WaitForDesiredState( 1449 TextInputStateHelper::WaitForDesiredState(
1442 embedder_web_contents(), 1450 embedder_web_contents(),
1443 base::Bind(&TextInputStateHelper::IsStateOfGivenType, 1451 base::Bind(&TextInputStateHelper::IsStateOfGivenType,
1444 ui::TEXT_INPUT_TYPE_NONE)); 1452 ui::TEXT_INPUT_TYPE_NONE));
1445 } 1453 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698