Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 1886553002: quick hackup of SkNx SkMatrixConvolutionImageFilter (Closed)

Created:
4 years, 8 months ago by mtklein_C
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

quick hackup of SkNx SkMatrixConvolutionImageFilter bench times drop on my laptop from ~12ms to ~6ms. The !convolveAlpha path seems very slightly different in precision. Not sure why yet. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1886553002

Patch Set 1 #

Patch Set 2 : tail too #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 2 3 chunks +11 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Stephen White
LGTM as long as you mark the appropriate Blink tests for rebaseline (if any)
4 years, 8 months ago (2016-04-13 12:08:49 UTC) #4
reed1
great speed gain, lgtm
4 years, 8 months ago (2016-04-13 13:28:24 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886553002/40001
4 years, 7 months ago (2016-05-05 17:52:55 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 18:08:45 UTC) #10
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698