Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188653003: ThreadWatcher: fixes Start/StopWatchingAll. (Closed)

Created:
6 years, 9 months ago by bulach
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

ThreadWatcher: fixes Start/StopWatchingAll. Start is deferred in relation to Stop, and when they're both called within the Start interval, the end result was started. Relands crrev.com/255322, fixing race condition in the test. BUG=347887, 349987 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255974

Patch Set 1 : Original patch, crrev.com/255322 #

Patch Set 2 : Fixes TSan #

Total comments: 4

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -2 lines) Patch
M chrome/browser/metrics/thread_watcher.h View 1 2 2 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/metrics/thread_watcher.cc View 5 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/metrics/thread_watcher_unittest.cc View 1 2 chunks +107 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bulach
raman: very sorry to keep bothering you. the previous patch got reverted, there was some ...
6 years, 9 months ago (2014-03-07 15:00:47 UTC) #1
ramant (doing other things)
lgtm https://codereview.chromium.org/188653003/diff/60001/chrome/browser/metrics/thread_watcher.h File chrome/browser/metrics/thread_watcher.h (right): https://codereview.chromium.org/188653003/diff/60001/chrome/browser/metrics/thread_watcher.h#newcode414 chrome/browser/metrics/thread_watcher.h:414: FRIEND_TEST_ALL_PREFIXES(ThreadWatcherListTest, Restart); nit: please consider moving line 414 ...
6 years, 9 months ago (2014-03-07 22:56:41 UTC) #2
bulach
thanks! comments addressed, CQing.. https://codereview.chromium.org/188653003/diff/60001/chrome/browser/metrics/thread_watcher.h File chrome/browser/metrics/thread_watcher.h (right): https://codereview.chromium.org/188653003/diff/60001/chrome/browser/metrics/thread_watcher.h#newcode414 chrome/browser/metrics/thread_watcher.h:414: FRIEND_TEST_ALL_PREFIXES(ThreadWatcherListTest, Restart); On 2014/03/07 22:56:41, ...
6 years, 9 months ago (2014-03-10 12:13:21 UTC) #3
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 9 months ago (2014-03-10 12:13:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/188653003/80001
6 years, 9 months ago (2014-03-10 12:14:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/188653003/80001
6 years, 9 months ago (2014-03-10 13:04:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/188653003/80001
6 years, 9 months ago (2014-03-10 14:19:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/188653003/80001
6 years, 9 months ago (2014-03-10 15:36:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/188653003/80001
6 years, 9 months ago (2014-03-10 17:34:47 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 18:10:11 UTC) #10
Message was sent while issue was closed. 
Change committed as 255974

Powered by Google App Engine
This is Rietveld 408576698