Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1886473002:
⛄ [Reland] Capture Android stderr when symbolizing native stack traces. (Closed)
Description[Reland] Capture Android stderr when symbolizing native stack traces.
When native->Java results in a Java exception, upon the stack returning
back to C++, we dump the Java exception to stderr and then signal a crash.
Update our stack tool to capture Java-formatted stderr while processing logcat and dump
all matching logs if the pid of the error matches the native stack.
While this may sometimes be irrelevant, it can often include the Java
exception and makes it easier to triage and less confusing.
BUG=602651
Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285
Cr-Commit-Position: refs/heads/master@{#386987}
Committed: https://crrev.com/85922ea529c280c58903a84056053c777485c118
Cr-Commit-Position: refs/heads/master@{#387029}
Patch Set 1 #Patch Set 2 : fix issue #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 ========== to ========== ⛄ Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 ==========
Description was changed from ========== ⛄ Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 ========== to ========== Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 ==========
yfriedman@chromium.org changed reviewers: + rmcilroy@chromium.org
On 2016/04/12 18:37:12, Yaron wrote: sample with a forced crash: https://paste.googleplex.com/5534017948483584
LGTM, thanks.
The CQ bit was checked by yfriedman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886473002/1
Message was sent while issue was closed.
Description was changed from ========== Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 ========== to ========== Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 ========== to ========== Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 Cr-Commit-Position: refs/heads/master@{#386987} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 Cr-Commit-Position: refs/heads/master@{#386987}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1884873004/ by timav@chromium.org. The reason for reverting is: Seems to cause exception failures on the bots: NameError: global name 'java_exceptions' is not defined E.g. https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We... What is |java_exceptions| at the end of stack_core.py?.
Message was sent while issue was closed.
oops, renamed but missed that spot, have a new fix coming On Wed, Apr 13, 2016 at 1:22 PM <timav@chromium.org> wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1884873004/ by timav@chromium.org. > > The reason for reverting is: Seems to cause exception failures on the bots: > NameError: global name 'java_exceptions' is not defined > > E.g. > > https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We... > > What is |java_exceptions| at the end of stack_core.py?. > > https://codereview.chromium.org/1886473002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Description was changed from ========== Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 Cr-Commit-Position: refs/heads/master@{#386987} ========== to ========== [Reland] Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 Cr-Commit-Position: refs/heads/master@{#386987} ==========
The CQ bit was checked by yfriedman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/1886473002/#ps20001 (title: "fix issue")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886473002/20001
Message was sent while issue was closed.
Description was changed from ========== [Reland] Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 Cr-Commit-Position: refs/heads/master@{#386987} ========== to ========== [Reland] Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 Cr-Commit-Position: refs/heads/master@{#386987} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Reland] Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 Cr-Commit-Position: refs/heads/master@{#386987} ========== to ========== [Reland] Capture Android stderr when symbolizing native stack traces. When native->Java results in a Java exception, upon the stack returning back to C++, we dump the Java exception to stderr and then signal a crash. Update our stack tool to capture Java-formatted stderr while processing logcat and dump all matching logs if the pid of the error matches the native stack. While this may sometimes be irrelevant, it can often include the Java exception and makes it easier to triage and less confusing. BUG=602651 Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 Cr-Commit-Position: refs/heads/master@{#386987} Committed: https://crrev.com/85922ea529c280c58903a84056053c777485c118 Cr-Commit-Position: refs/heads/master@{#387029} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/85922ea529c280c58903a84056053c777485c118 Cr-Commit-Position: refs/heads/master@{#387029} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
