Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1886463003: Remove the Presentation Mode Command ID (Closed)

Created:
4 years, 8 months ago by spqchan
Modified:
4 years, 8 months ago
Reviewers:
erikchen, Nico
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Presentation Mode Command ID Removed the following: - References to the Presentation Mode command and menu item - Logic that determines the visibility of the fullscreen menu items - Dead code in ExclusiveAccessBubbleWindowController BUG=579259 Committed: https://crrev.com/5c95f60438ba23e8793b1b0858518b238bfe2320 Cr-Commit-Position: refs/heads/master@{#387036}

Patch Set 1 #

Patch Set 2 : Removed some 10.6 logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -98 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/app/nibs/MainMenu.xib View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_command_handler.mm View 1 3 chunks +2 lines, -37 lines 0 comments Download
M chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller.mm View 2 chunks +0 lines, -39 lines 0 comments Download
M chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
spqchan
PTAL
4 years, 8 months ago (2016-04-13 17:16:09 UTC) #6
erikchen
lgtm
4 years, 8 months ago (2016-04-13 17:18:36 UTC) #7
spqchan
+thakis for OWNERS
4 years, 8 months ago (2016-04-13 17:23:26 UTC) #9
Nico
lgtm
4 years, 8 months ago (2016-04-13 17:42:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886463003/20001
4 years, 8 months ago (2016-04-13 17:44:50 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 18:27:28 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:29:55 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c95f60438ba23e8793b1b0858518b238bfe2320
Cr-Commit-Position: refs/heads/master@{#387036}

Powered by Google App Engine
This is Rietveld 408576698