Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7329)

Unified Diff: base/message_loop/message_pump_perftest.cc

Issue 1886453003: Make PendingTask move-only and pass it by value on retaining params (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mac test fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop/message_loop.cc ('k') | base/pending_task.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_pump_perftest.cc
diff --git a/base/message_loop/message_pump_perftest.cc b/base/message_loop/message_pump_perftest.cc
index 7bb942fa657707f2e9de8112d3e3b868435aa33e..6cf89bdf74492e5da9b7b142a19f0e4d6c8c3bb8 100644
--- a/base/message_loop/message_pump_perftest.cc
+++ b/base/message_loop/message_pump_perftest.cc
@@ -271,7 +271,7 @@ class PostTaskTest : public testing::Test {
TaskQueue loop_local_queue;
queue->ReloadWorkQueue(&loop_local_queue);
while (!loop_local_queue.empty()) {
- PendingTask t = loop_local_queue.front();
+ PendingTask t = std::move(loop_local_queue.front());
loop_local_queue.pop();
loop.RunTask(t);
}
« no previous file with comments | « base/message_loop/message_loop.cc ('k') | base/pending_task.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698