components/scheduler/base/task_queue_manager.cc - Issue 1886453003: Make PendingTask move-only and pass it by value on retaining params

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/base/task_queue_manager.cc

Issue 1886453003: Make PendingTask move-only and pass it by value on retaining params (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: disable WorkQueue copy Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/base/task_queue_impl.cc ('K') | « components/scheduler/base/task_queue_impl.cc ('k') | components/scheduler/base/work_queue.h » ('j') | components/scheduler/base/work_queue.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/base/task_queue_manager.cc

diff --git a/components/scheduler/base/task_queue_manager.cc b/components/scheduler/base/task_queue_manager.cc

index fcbabe4950cc612074caf5ffa0a75feaf831a6a5..9c9e91656f253914b64735f2ba40b26451a9289e 100644

--- a/components/scheduler/base/task_queue_manager.cc

+++ b/components/scheduler/base/task_queue_manager.cc

@@ -302,7 +302,7 @@ TaskQueueManager::ProcessTaskResult TaskQueueManager::ProcessTaskFromWorkQueue(

}

pending_task.task.Reset();

- *out_previous_task = pending_task;

+ *out_previous_task = std::move(pending_task);

return ProcessTaskResult::EXECUTED;

}