Gerrit git cl upload: implement patchset title (message).

tests/git_cl_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for git_cl.py."""
 
 import os
 import StringIO
 import stat
@@ skipping 720 matching lines @@
         ((['git', 'config', 'user.email'],), 'me@example.com'),
         ((['git',
            'diff', '--no-ext-diff', '--stat', '--find-copies-harder',
            '-l100000', '-C50', 'fake_ancestor_sha', 'HEAD'],),
          '+dat'),
       ]
 
   @classmethod
   def _gerrit_upload_calls(cls, description, reviewers, squash,
                            expected_upstream_ref='origin/refs/heads/master',
+                           ref_suffix='',
                            post_amend_description=None, issue=None):
     if post_amend_description is None:
       post_amend_description = description
 
     calls = [
         ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), 'false'),
     ]
     # If issue is given, then description is fetched from Gerrit instead.
     if issue is None:
       if squash:
@@ skipping 52 matching lines @@
     receive_pack = '--receive-pack=git receive-pack '
     receive_pack += '--cc=joe@example.com'  # from watch list
     if reviewers:
       receive_pack += ' '
       receive_pack += ' '.join(
           '--reviewer=' + email for email in sorted(reviewers))
     receive_pack += ''
     calls += [
         ((['git',
            'push', receive_pack, 'origin',
-           ref_to_push + ':refs/for/refs/heads/master'],),
+           ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
          ('remote:\n'
          'remote: Processing changes: (\)\n'
          'remote: Processing changes: (|)\n'
          'remote: Processing changes: (/)\n'
          'remote: Processing changes: (-)\n'
          'remote: Processing changes: new: 1 (/)\n'
          'remote: Processing changes: new: 1, done\n'
          'remote:\n'
          'remote: New Changes:\n'
          'remote:   https://chromium-review.googlesource.com/123456 XXX.\n'
          'remote:\n'
          'To https://chromium.googlesource.com/yyy/zzz\n'
          ' * [new branch]      hhhh -> refs/for/refs/heads/master\n')),
         ]
     if squash:
       calls += [
           ((['git', 'config', 'branch.master.gerritissue', '123456'],), ''),
           ((['git', 'config', 'branch.master.gerritserver',
           'https://chromium-review.googlesource.com'],), ''),
           ((['git', 'config', 'branch.master.gerritsquashhash',
              'abcdef0123456789'],), ''),
       ]
     calls += cls._git_post_upload_calls()
     return calls
 
   def _run_gerrit_upload_test(
       self,
       upload_args,
       description,
-      reviewers,
+      reviewers=None,
       squash=False,
       expected_upstream_ref='origin/refs/heads/master',
+      ref_suffix='',
       post_amend_description=None,
       issue=None):
     """Generic gerrit upload test framework."""
+    reviewers = reviewers or []
     self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
               CookiesAuthenticatorMockFactory(same_cookie='same_cred'))
     self.calls = self._gerrit_base_calls(issue=issue)
     self.calls += self._gerrit_upload_calls(
         description, reviewers, squash,
         expected_upstream_ref=expected_upstream_ref,
+        ref_suffix=ref_suffix,
         post_amend_description=post_amend_description,
         issue=issue)
     # Uncomment when debugging.
     # print '\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))
     git_cl.main(['upload'] + upload_args)
 
   def test_gerrit_upload_without_change_id(self):
     self.mock(git_cl, 'DownloadGerritHook', self._mocked_call)
     self._run_gerrit_upload_test(
         [],
         'desc\n\nBUG=\n',
         [],
         post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx')
 
   def test_gerrit_no_reviewer(self):
     self._run_gerrit_upload_test(
         [],
         'desc\n\nBUG=\n\nChange-Id: I123456789\n',
         [])
 
+  def test_gerrit_patch_title(self):
+    self._run_gerrit_upload_test(
+        ['-t', 'Don\'t put under_scores as they become spaces'],
+        'desc\n\nBUG=\n\nChange-Id: I123456789',
+        ref_suffix='%m=Don\'t_put_under_scores_as_they_become_spaces')
+
   def test_gerrit_reviewers_cmd_line(self):
     self._run_gerrit_upload_test(
         ['-r', 'foo@example.com'],
         'desc\n\nBUG=\n\nChange-Id: I123456789',
         ['foo@example.com'])
 
   def test_gerrit_reviewer_multiple(self):
     self._run_gerrit_upload_test(
         [],
         'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n\n'
@@ skipping 403 matching lines @@
       'chromium.googlesource.com': 'same',
       'chromium-review.googlesource.com': 'same',
     })
     self.assertIsNone(cl.EnsureAuthenticated(force=False))
 
 
 if __name__ == '__main__':
   git_cl.logging.basicConfig(
       level=git_cl.logging.DEBUG if '-v' in sys.argv else git_cl.logging.ERROR)
   unittest.main()