Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188643005: Update V8 to version 3.25.5 (based on bleeding_edge revision r19695). (Closed)

Created:
6 years, 9 months ago by Jakob Kummerow
Modified:
6 years, 9 months ago
Reviewers:
titzer
CC:
chromium-reviews
Visibility:
Public.

Description

Update V8 to version 3.25.5 (based on bleeding_edge revision r19695). TBR=titzer@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Jakob Kummerow
6 years, 9 months ago (2014-03-06 18:01:52 UTC) #1
Jakob Kummerow
The CQ bit was checked by jkummerow@chromium.org
6 years, 9 months ago (2014-03-06 18:06:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkummerow@chromium.org/188643005/1
6 years, 9 months ago (2014-03-06 18:08:37 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 18:16:11 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 18:16:11 UTC) #5
Jakob Kummerow
The CQ bit was checked by jkummerow@chromium.org
6 years, 9 months ago (2014-03-06 18:18:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkummerow@chromium.org/188643005/1
6 years, 9 months ago (2014-03-06 18:21:20 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 18:27:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-06 18:27:40 UTC) #9
Jakob Kummerow
The CQ bit was checked by jkummerow@chromium.org
6 years, 9 months ago (2014-03-06 21:11:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkummerow@chromium.org/188643005/1
6 years, 9 months ago (2014-03-06 21:18:28 UTC) #11
Jakob Kummerow
Committed patchset #1 manually as r255443 (presubmit successful).
6 years, 9 months ago (2014-03-06 22:04:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkummerow@chromium.org/188643005/1
6 years, 9 months ago (2014-03-06 22:05:51 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 22:05:55 UTC) #14
Message was sent while issue was closed. 
Failed to apply patch for DEPS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file DEPS
  Hunk #1 FAILED at 51.
  1 out of 1 hunk FAILED -- saving rejects to file DEPS.rej

Patch:       DEPS
Index: DEPS
diff --git a/DEPS b/DEPS
index
a31e40a6ff5fadb6972c5c9f3a14d624d6e93fa6..a545dcd706154b6fb1d898ad6c2e08aca249e245
100644
--- a/DEPS
+++ b/DEPS
@@ -51,7 +51,7 @@ vars = {
   # the commit queue can handle CLs rolling Skia
   # and V8 without interference from each other.
   "v8_branch": "trunk",
-  "v8_revision": "19680",
+  "v8_revision": "19696",
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling WebRTC
   # and V8 without interference from each other.

Powered by Google App Engine
This is Rietveld 408576698