Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188643003: DevTools: Simplify Page.captureScreenshot API (Blink side) (Closed)

Created:
6 years, 9 months ago by Vladislav Kaznacheev
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Simplify Page.captureScreenshot API (Blink side) BUG=242405 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169974

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M Source/devtools/protocol.json View 1 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Vladislav Kaznacheev
6 years, 9 months ago (2014-03-24 13:41:30 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-25 16:33:09 UTC) #2
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 9 months ago (2014-03-25 16:36:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/188643003/20001
6 years, 9 months ago (2014-03-25 16:36:43 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 17:12:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-25 17:12:04 UTC) #6
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 9 months ago (2014-03-25 18:36:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/188643003/20001
6 years, 9 months ago (2014-03-25 18:37:07 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 19:28:35 UTC) #9
Message was sent while issue was closed. 
Change committed as 169974

Powered by Google App Engine
This is Rietveld 408576698