Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 188643002: Bugfix for 349874: we incorrectly believe we saw a growing store (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/regress/regress-349885.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5067 matching lines...) Expand 10 before | Expand all | Expand 10 after
5078 ASSERT(!instr->hydrogen()->IsOldDataSpaceAllocation()); 5078 ASSERT(!instr->hydrogen()->IsOldDataSpaceAllocation());
5079 ASSERT(!instr->hydrogen()->IsNewSpaceAllocation()); 5079 ASSERT(!instr->hydrogen()->IsNewSpaceAllocation());
5080 flags = static_cast<AllocationFlags>(flags | PRETENURE_OLD_POINTER_SPACE); 5080 flags = static_cast<AllocationFlags>(flags | PRETENURE_OLD_POINTER_SPACE);
5081 } else if (instr->hydrogen()->IsOldDataSpaceAllocation()) { 5081 } else if (instr->hydrogen()->IsOldDataSpaceAllocation()) {
5082 ASSERT(!instr->hydrogen()->IsNewSpaceAllocation()); 5082 ASSERT(!instr->hydrogen()->IsNewSpaceAllocation());
5083 flags = static_cast<AllocationFlags>(flags | PRETENURE_OLD_DATA_SPACE); 5083 flags = static_cast<AllocationFlags>(flags | PRETENURE_OLD_DATA_SPACE);
5084 } 5084 }
5085 5085
5086 if (instr->size()->IsConstantOperand()) { 5086 if (instr->size()->IsConstantOperand()) {
5087 int32_t size = ToInteger32(LConstantOperand::cast(instr->size())); 5087 int32_t size = ToInteger32(LConstantOperand::cast(instr->size()));
5088 if (size <= Page::kMaxRegularHeapObjectSize) { 5088 __ Allocate(size, result, temp, no_reg, deferred->entry(), flags);
5089 __ Allocate(size, result, temp, no_reg, deferred->entry(), flags);
5090 } else {
5091 __ jmp(deferred->entry());
5092 }
5093 } else { 5089 } else {
5094 Register size = ToRegister(instr->size()); 5090 Register size = ToRegister(instr->size());
5095 __ Allocate(size, result, temp, no_reg, deferred->entry(), flags); 5091 __ Allocate(size, result, temp, no_reg, deferred->entry(), flags);
5096 } 5092 }
5097 5093
5098 __ bind(deferred->exit()); 5094 __ bind(deferred->exit());
5099 5095
5100 if (instr->hydrogen()->MustPrefillWithFiller()) { 5096 if (instr->hydrogen()->MustPrefillWithFiller()) {
5101 if (instr->size()->IsConstantOperand()) { 5097 if (instr->size()->IsConstantOperand()) {
5102 int32_t size = ToInteger32(LConstantOperand::cast(instr->size())); 5098 int32_t size = ToInteger32(LConstantOperand::cast(instr->size()));
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
5583 FixedArray::kHeaderSize - kPointerSize)); 5579 FixedArray::kHeaderSize - kPointerSize));
5584 __ bind(&done); 5580 __ bind(&done);
5585 } 5581 }
5586 5582
5587 5583
5588 #undef __ 5584 #undef __
5589 5585
5590 } } // namespace v8::internal 5586 } } // namespace v8::internal
5591 5587
5592 #endif // V8_TARGET_ARCH_X64 5588 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/regress/regress-349885.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698