Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 188643002: Bugfix for 349874: we incorrectly believe we saw a growing store (Closed)

Created:
6 years, 9 months ago by mvstanton
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev, Igor Sheludko
Visibility:
Public.

Description

Bugfix for 349874: we incorrectly believe we saw a growing store When we set an out of bounds array index, the index might be so large that it causes the array to go to dictionary mode. It's better to avoid "learning" that this was a growing store in that case. This fix also partially reverts a fix for bug 347543, as this fix is comprehensive and satisfies that repro case as well (partial revert of v19591). BUG=349874 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19691

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M src/a64/lithium-codegen-a64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/ic.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -5 lines 0 comments Download
A + test/mjsunit/regress/regress-349885.js View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Toon, Here is what we discussed, PTAL, --Michael
6 years, 9 months ago (2014-03-06 12:59:32 UTC) #1
Toon Verwaest
lgtm
6 years, 9 months ago (2014-03-06 13:03:06 UTC) #2
mvstanton
6 years, 9 months ago (2014-03-06 13:08:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19691 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698